On Mon, Mar 05, 2018 at 08:30:40PM -0800, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180306040154.3669-1-da...@gibson.dropbear.id.au > Subject: [Qemu-devel] [PULL 00/30] ppc-for-2.12 queue 20180306 > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/20180306040154.3669-1-da...@gibson.dropbear.id.au -> > patchew/20180306040154.3669-1-da...@gibson.dropbear.id.au > Switched to a new branch 'test' > 710332af72 PowerPC: Add TS bits into msr_mask > 1d843d531b adb: add trace-events for monitoring keyboard/mouse during bus > enumeration > e0dcafa414 PPC: e500: Fix duplicate kernel load and device tree overlap > ca32627c89 hw/ppc/spapr, e500: Use new property "stdout-path" for boot console > 7ec999efd1 ppc/spapr-caps: Define the pseries-2.12-sxxm machine type > c5c9d5e6b5 ppc/spapr-caps: Convert cap-ibs to custom spapr-cap > d1f8d2a7ec ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap > dee8ac698b ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap > be78220976 ppc/spapr-caps: Add support for custom spapr_capabilities > 41fe6c3234 target/ppc: Check mask when setting cap_ppc_safe_indirect_branch > 925dc8c8ab macio: remove macio_init() function > 0cdc7ef4d3 macio: move setting of CUDA timebase frequency to > macio_common_realize() > 333e2d72ae mac_newworld: use object link to pass OpenPIC object to macio > 6352921fc0 openpic: move OpenPIC state and related definitions to openpic.h > f6528ecaad openpic: move KVM-specific declarations into separate > openpic_kvm.h file > ff45ce713e mac_oldworld: use object link to pass heathrow PIC object to macio > 7a6c79ea44 macio: move macio related structures and defines into separate > macio.h file > 314c9858ad heathrow: change heathrow_pic_init() to return the heathrow device > f5b91571dc heathrow: convert to trace-events > 3045694ed1 heathrow: QOMify heathrow PIC > ad17492d9b macio: move ESCC device within the macio device > 777c94a3ee macio: embed DBDMA device directly within macio > 2ea90e405c spapr: harden code that depends on VSMT > 00226ad7c9 spapr: register dummy ICPs later > 7ed96e066b ppc: Add aCube Sam460ex board > 9abb284ab2 pc-bios: Added u-boot-sam460 firmware binary > e4cb279fb1 roms: Added git submodule for u-boot-sam460 (firmware for sam460ex) > a2279cf053 ppc440: Add emulation of plb-pcix controller found in some 440 SoCs > 3e9afde83e ppc440_uc: Fix unintialized variable warning with older gcc > 8e4c18ae65 spapr: fix missing CPU core nodes in DT when running with TCG > > === OUTPUT BEGIN === > Checking PATCH 1/30: spapr: fix missing CPU core nodes in DT when running > with TCG... > Checking PATCH 2/30: ppc440_uc: Fix unintialized variable warning with older > gcc... > Checking PATCH 3/30: ppc440: Add emulation of plb-pcix controller found in > some 440 SoCs... > Checking PATCH 4/30: roms: Added git submodule for u-boot-sam460 (firmware > for sam460ex)... > Checking PATCH 5/30: pc-bios: Added u-boot-sam460 firmware binary... > Checking PATCH 6/30: ppc: Add aCube Sam460ex board... > Checking PATCH 7/30: spapr: register dummy ICPs later... > Checking PATCH 8/30: spapr: harden code that depends on VSMT... > Checking PATCH 9/30: macio: embed DBDMA device directly within macio... > Checking PATCH 10/30: macio: move ESCC device within the macio device... > Checking PATCH 11/30: heathrow: QOMify heathrow PIC... > Checking PATCH 12/30: heathrow: convert to trace-events... > Checking PATCH 13/30: heathrow: change heathrow_pic_init() to return the > heathrow device... > Checking PATCH 14/30: macio: move macio related structures and defines into > separate macio.h file... > Checking PATCH 15/30: mac_oldworld: use object link to pass heathrow PIC > object to macio... > Checking PATCH 16/30: openpic: move KVM-specific declarations into separate > openpic_kvm.h file... > Checking PATCH 17/30: openpic: move OpenPIC state and related definitions to > openpic.h... > ERROR: "foo * bar" should be "foo *bar" > #250: FILE: include/hw/ppc/openpic.h:57: > +#define RAVEN_DBL_IRQ (RAVEN_IPI_IRQ + (RAVEN_MAX_CPU * RAVEN_MAX_IPI)) > > total: 1 errors, 0 warnings, 353 lines checked
This is a false positive. For some reason it's misidentifying a multiply as a dereference. > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 18/30: mac_newworld: use object link to pass OpenPIC object to > macio... > Checking PATCH 19/30: macio: move setting of CUDA timebase frequency to > macio_common_realize()... > Checking PATCH 20/30: macio: remove macio_init() function... > Checking PATCH 21/30: target/ppc: Check mask when setting > cap_ppc_safe_indirect_branch... > Checking PATCH 22/30: ppc/spapr-caps: Add support for custom > spapr_capabilities... > Checking PATCH 23/30: ppc/spapr-caps: Convert cap-cfpc to custom spapr-cap... > Checking PATCH 24/30: ppc/spapr-caps: Convert cap-sbbc to custom spapr-cap... > Checking PATCH 25/30: ppc/spapr-caps: Convert cap-ibs to custom spapr-cap... > Checking PATCH 26/30: ppc/spapr-caps: Define the pseries-2.12-sxxm machine > type... > Checking PATCH 27/30: hw/ppc/spapr, e500: Use new property "stdout-path" for > boot console... > Checking PATCH 28/30: PPC: e500: Fix duplicate kernel load and device tree > overlap... > Checking PATCH 29/30: adb: add trace-events for monitoring keyboard/mouse > during bus enumeration... > Checking PATCH 30/30: PowerPC: Add TS bits into msr_mask... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
