On 22/02/2018 22:58, Eric Blake wrote:
> Sometimes, we want to refer to really long URLs, but checkpatch
> balks, and we have to manually bypass the check. URL shorterners
> may be nice at reducing long links, but it's hard to guarantee the
> shortened link will live as long as the real target, and it is
> also nice to see the original target without having to load the
> shortened URL through a browser. So exempt a line containing
> only a URL from the long-line syntax check.
>
> Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> Signed-off-by: Eric Blake <ebl...@redhat.com>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 1b4b812e28f..0d3f753c665 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1447,9 +1447,10 @@ sub process {
> # check we are in a valid source file if not then ignore this hunk
> next if ($realfile !~ /$SrcFile/);
>
> -#90 column limit
> +#90 column limit; exempt URLs, if no other words on line
> if ($line =~ /^\+/ &&
> !($line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
> + !($rawline =~ /^[^[:alnum:]]*https?:\S*$/) &&
> $length > 80)
> {
> if ($length > 90) {
>
Queued, thanks.
Paolo
