On Wed, Mar 07, 2018 at 07:59:09PM +0100, Kevin Wolf wrote: > This series implements a minimal QMP command that allows to create an > image file on the protocol level or an image format on a given block > node. > > Eventually, the interface is going to change to some kind of an async > command (possibly a (non-)block job), but that will require more work on > the job infrastructure first, so let's first QAPIfy image creation in > the block drivers. In this series, I'm going for a synchronous command > that is prefixed with x- for now. > > This series converts qcow2 and all protocol drivers that allow an actual > image creation. This means that drivers which only check if the already > existing storage is good enough are not converted (e.g. host_device, > iscsi). The old behaviour was useful because 'qemu-img create' wants to > create both protocol and format layer, but with the separation in QMP, > you can just leave out the protocol layer creation when the device > already exists.
Are you going to convert the other format drivers in later versions of this series, or leave it upto individual maintaniers to convert the rest ? (personally thinking of the luks driver of course) Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|