On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > Blacklist the following commands to fix the 'make check' failure. > > query-sev-launch-measure: it returns meaninful data only when we launch > SEV guest otherwise the command returns an error. > > query-sev: it return an error when SEV is not available on host (e.g non > X86 platform or KVM is disabled at the build time) > > query-sev-capabilities: it returns an error when SEV feature is not > available on host machine.
We generally expect 'make check' to succeed on every single patch in a series, so that 'git bisect' doesn't break. So you should add each command to the blacklist in the same commit that introduced the failure in the first place. > > Cc: "Daniel P. Berrangé" <berra...@redhat.com> > Cc: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > Cc: Markus Armbruster <arm...@redhat.com> > Reviewed-by: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> > --- > tests/qmp-test.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/qmp-test.c b/tests/qmp-test.c > index 22445d9ec258..7470c6b754bc 100644 > --- a/tests/qmp-test.c > +++ b/tests/qmp-test.c > @@ -204,6 +204,11 @@ static bool query_is_blacklisted(const char *cmd) > "query-gic-capabilities", /* arm */ > /* Success depends on target-specific build configuration: */ > "query-pci", /* CONFIG_PCI */ > + /* Success depends on launching SEV guest */ > + "query-sev-launch-measure", > + /* Success depends on Host or Hypervisor SEV support */ > + "query-sev", > + "query-sev-capabilities", > NULL > }; > int i; > -- > 2.14.3 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
