On 13/03/2018 12:28, Brijesh Singh wrote:
>
>
> On 3/13/18 4:33 AM, Paolo Bonzini wrote:
>> On 08/03/2018 13:48, Brijesh Singh wrote:
>>> sev_set_guest_state(SEV_STATE_RUNNING);
>>> +
>>> + /* add migration blocker */
>>> + error_setg(&sev_mig_blocker,
>>> + "SEV: Migration is not implemented");
>>> + ret = migrate_add_blocker(sev_mig_blocker, &local_err);
>>> + if (local_err) {
>>> + error_report_err(local_err);
>>> + error_free(sev_mig_blocker);
>>> + exit(1);
>>> + }
>>> }
>> I think this should be in sev_guest_init instead? Does migration
>> transfer the measurement, or is it lost forever? Not a blocker though.
>
> The launch measurement does not get transferred during the migration.
> During migration we get totally different measurement which is wrapped
> with transport key etc and that need to send to destination. IIRC, in my
> first attempt I was adding this blocker in sev_guest_init() but
> migration_add_blocker() was failing because sev_guest_init() is called
> before the migration_object_init().
I see, thanks. I'm not going to touch this part anyway. :)
We can fix it during the freeze period.
Paolo
