On 16 March 2018 at 17:11, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 16/03/2018 18:01, Andrew Jones wrote: >> Hi Thomas, >> >> QEMU master is failing to build on an AArch64 machine with GCC 4.8. I get >> >> ... >> CC qemu-nbd.o >> /home/drjones/code/qemu/qemu-nbd.c: In function ‘version’: >> /home/drjones/code/qemu/qemu-nbd.c:133:7: error: expected ‘)’ before >> ‘QEMU_FULL_VERSION’ >> "%s " QEMU_FULL_VERSION "\n" >> ^ >> /home/drjones/code/qemu/qemu-nbd.c:139:5: error: format ‘%s’ expects a >> matching ‘char *’ argument [-Werror=format=] >> , name); >> ^ >> cc1: all warnings being treated as errors >> make: *** [qemu-nbd.o] Error 1 >> >> >> Reverting 7e563bfb8 fixes the build. I figured I'd report it now, >> but I won't have time to look closer until Monday. > > You probably have a stray qemu-version.h file somewhere. No worries, I > was puzzled by the same thing after I applied Thomas's patch. :)
Yep, stray qemu-version.h in the source tree. That bit me on one of my build systems and also mstsirkin... (MST had a suggestion on IRC that if we used #include <> for generated headers rather than "" this would avoid that problem because it would not search the source tree before the build tree. I haven't tested that idea...) thanks -- PMM