Hi Jay, Excellent work! The patch, although need some minor rework, has improved the performance. Some comments:
1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost crypto proxy backend only AESCBC and SHA1 are supported (in cryptodev_vhost_user_init() definition), I believe in this version these two algorithms shall be enough. Actually for the same reason I suggest you to remove all AES_CTR test cases in the virtio_crypto PMD functional test, as they will fail when vhost_user crypto backend is used. You may use driver/crypto/qat/qat_crypto_capabilities.h as example. The const capabilities array shall be returned to the application when virtio_crypto_dev_info_get() is called. 2. there is a bug in virtio_crypto_queue_setup(), you declared " uint32_t i, j;" while i may be used uninitialized later. Regards, Fan > -----Original Message----- > From: Jay Zhou [mailto:jianjay.z...@huawei.com] > Sent: Tuesday, January 16, 2018 2:07 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; weidong.hu...@huawei.com; > stefa...@redhat.com; jianjay.z...@huawei.com; > pa...@linux.vnet.ibm.com; longpe...@huawei.com; Zeng, Xin > <xin.z...@intel.com>; Zhang, Roy Fan <roy.fan.zh...@intel.com>; > arei.gong...@huawei.com > Subject: [PATCH v3 3/4] cryptodev-vhost-user: add crypto session handler >
