Hi Yuval, On 20/03/2018 21:00, Yuval Shaia wrote: > Please review implementation of Query QP verb which is needed by some RDMA > applications. > > Patch #1: Implementation in rdma backend layer > Patch #2: Add support to pvrdma device > > v0 -> v1: > * Split to two patches, one for rdma and one for pvrdma >
Actually previous version was V1, this one is V2 :) Next time please add V2 (V3...) prefix and I suggest using --cover-letter when using git format-patch/send email instead of manually adding it. > [PATCH v1 1/2] hw/rdma: Add Query QP operation > [PATCH v1 2/2] hw/rdma: Add support for Query QP verb to pvrdma Second patch should have maybe rdma/vmw since is VMware specific (next time) > I am thinking adding it to 2.12, it can be seen as a bug-fix, querying QP is a basic operation the device should answer to. Michael, sounds reasonable? Reviewed-by: Marcel Apfelbaum <mar...@redhat.com> Thanks, Marcel