On 03/21/2018 01:27 PM, Michael Clark wrote:
for future PULL request, could you please send out all patches again
that should be pulled, and not send the cover letter alone? I.e. do a
"git format-patch --subject-prefix PULL ..." and then replace the
contents of the cover letter with the output of "git request-pull".
No problem. Thanks for the advice. I was grappling with this part of the
process. This is now very clear and makes complete sense.
You'll notice that some maintainers send a full PULL request the first
time, but if they have to send a v2, they only include the patches that
changed from v1. That's also okay (there's still an email for each
patch in the series as it eventually got committed, even if it is now
split across threads; but that is sufficient for someone performing a
bisect to have an easy email to reply to when reporting a regression
caused by the final version that ended up getting pulled). For an
example of that, see my QAPI v4 request:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05160.html
and the regression report against the v1 request (since that particular
patch did not change between v1 and v4):
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03611.html
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05709.html
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
