On 03/22/2018 05:53 AM, Peter Maydell wrote: > On 22 March 2018 at 08:01, Andrew Jones <drjo...@redhat.com> wrote: >> I agree we should change the useless 1.0, but shouldn't we use >> mc->name instead of mc->desc? mc->name would make it consistent >> with pc-piix and q35 and also be a less verbose "version". We'd >> get e.g. >> >> System Information >> Manufacturer: QEMU >> Product Name: KVM Virtual Machine >> Version: virt-2.12 >> Serial Number: Not Specified > > I would vote for consistency with x86, I think.
Drew and you like ->name better because of its conciseness consistency with x86. In my view virt-2.xx is not very informative. "Version" info in real machine could be verbose. Using my Thinkpad as example: Manufacturer: LENOVO Product Name: 20FAS1EG0N Version: ThinkPad T460s With that said, I will change it to mc->name. > > thanks > -- PMM >