On Thu, Mar 22, 2018 at 02:42:55PM -0500, Eric Blake wrote: > On 03/22/2018 02:27 PM, Michael S. Tsirkin wrote: > > Make sure all generated files go into qemu-build subdirectory. > > We can then include them like this: > > #include "qemu-build/trace.h" > > > > This serves two purposes: > > - make it easy to detect which files are in the source > > directory (a bit more work for writers, easier for readers) > > - reduce chances of conflicts with possible stale files in source > > directory (which could be left over from e.g. old patches, etc) > > > > This patch needs to be merged with patch 2 of series updating all > > files: sending it separately to avoid spamming the list. > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > --- > > > +++ b/Makefile > > @@ -89,102 +89,102 @@ endif > > include $(SRC_PATH)/rules.mak > > -GENERATED_FILES = qemu-version.h config-host.h qemu-options.def > > -GENERATED_FILES += qapi/qapi-builtin-types.h qapi/qapi-builtin-types.c > > Uggh - I really need to follow up on my threat to make smarter use of make > variables and string manipulation to cut down on the boilerplate involved > here. Sadly, I'm not convinced that doing so is a 2.12 bugfix priority, so > it isn't at the top of my work queue. > > Overall, the patch is an interesting idea. I'm still not 100% sold on it > (as you say, it's now slightly more work for writers), but I'm not coming up > with any solid reasons why it should not be applied (at least, for 2.13 - > doing it during freeze for 2.12 is a bit harder to justify).
It's up to Peter really: it helps reduce conflicts if we apply patches like this during freeze. But with enough effort on Pater's part it's not a huge deal. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
