On 03/23/2018 02:01 PM, Peter Xu wrote: > On Fri, Mar 23, 2018 at 01:44:54PM +0100, Christian Borntraeger wrote: >> >> >> On 03/23/2018 01:25 PM, Peter Xu wrote: >>> On Fri, Mar 23, 2018 at 01:10:51PM +0100, Christian Borntraeger wrote: >>>> As Max Reitz said, this breaks several qemu iotests. I can reproduce that >>>> on s390 >>>> e.g. with ./check -qcow2 030 in the qemu-iotest. >>>> >>>> Why was this merged? >>> >>> My fault. Sorry. I should have done iotests before submission. >>> >>> Now I'm trying to fix those iotest issues. >>> >>> I'm not extremely familiar with block, so the progress is a bit slow, >>> but I'll do it asap (though I'll possibly need some help from the >>> block team, since there are some not-easy ones for me). >> >> As this patch also seems to trigger something else for Eric, can we revert >> this >> patch for the time being and re-apply as soon as we have solutions for the >> issues? >> >> After all a hard hang in the iotest can break CI environments (as you run >> into timeouts). > > I'm fine with it if it helps. > > Then I can work in background to solved existing problems, then we > turn it on again in 2.13 when ready (but still it might break things - > at least it can be during dev cycle rather than softfreeze).
Strangely enough, reverting 3fd2457d18edf5736f713dfe1 now causes make check errors... :-/ GTESTER check-qtest-s390x GTESTER check-qtest-i386 ** ERROR:/home/cborntra/REPOS/qemu/tests/qmp-test.c:97:test_qmp_protocol: assertion failed: (entry) GTester: last random seed: R02S1cbb7e297cc349b33ae39f10dd92764a ** ERROR:/home/cborntra/REPOS/qemu/tests/qmp-test.c:190:test_qmp_oob: assertion failed: (qdict_haskey(resp, "return")) GTester: last random seed: R02S7afc5ab63f6f29401d702dceb1f8030b make: *** [/home/cborntra/REPOS/qemu/tests/Makefile.include:880: check-qtest-s390x] Error 1 make: *** Waiting for unfinished jobs.... ^Cmake: *** [/home/cborntra/REPOS/qemu/tests/Makefile.include:880: check-qtest-i386] Interrupt Do we have patches depending on this change?
