On 26/03/2018 13:20, Vladimir Sementsov-Ogievskiy wrote: > Nothing critical here. > > 01 - these functions are unused for now, but the will be used in > the qmp bitmaps api. > > Vladimir Sementsov-Ogievskiy (7): > block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap > dirty-bitmaps: fix comment about dirty_bitmap_mutex > dirty-bitmap: remove missed bdrv_dirty_bitmap_get_autoload header > dirty-bitmap: separate unused meta-bitmap related functions > blockdev: refactor block-dirty-bitmap-clear transaction > block/dirty-bitmap: bdrv_clear_dirty_bitmap: drop unused parameter > blockdev: unify block-dirty-bitmap-clear command and transaction > action > > include/block/block_int.h | 14 +++++---- > include/block/dirty-bitmap.h | 15 ++++++---- > block/dirty-bitmap.c | 23 +++++++++------ > blockdev.c | 69 > ++++++++++++++------------------------------ > 4 files changed, 54 insertions(+), 67 deletions(-) >
Looks good apart from some dead code still being there. Paolo
