Re: [Qemu-devel] [PATCH v4 2/2] tpm: extend TPM TIS with state migration support

[Stefan Berger]

On 03/29/2018 01:07 PM, Marc-André Lureau wrote:

Hi

On Thu, Mar 29, 2018 at 1:56 AM, Stefan Berger
<stef...@linux.vnet.ibm.com> wrote:

On 03/28/2018 11:41 AM, Marc-André Lureau wrote:

Hi

On Thu, Mar 1, 2018 at 8:59 PM, Stefan Berger
<stef...@linux.vnet.ibm.com> wrote:

+
+static const VMStateDescription vmstate_locty = {
+    .name = "loc",
+    .version_id = 1,
+    .minimum_version_id = 0,
+    .minimum_version_id_old = 0,

I don't understand the problem there is leaving all the version fields
to 0, just like CRB.

+    .fields      = (VMStateField[]) {
+        VMSTATE_UINT32(state, TPMLocality),
+        VMSTATE_UINT32(inte, TPMLocality),
+        VMSTATE_UINT32(ints, TPMLocality),
+        VMSTATE_UINT8(access, TPMLocality),
+        VMSTATE_UINT32(sts, TPMLocality),
+        VMSTATE_UINT32(iface_id, TPMLocality),
+        VMSTATE_END_OF_LIST(),
+    }
+};
+
   static const VMStateDescription vmstate_tpm_tis = {
       .name = "tpm",
-    .unmigratable = 1,
+    .version_id = 1,
+    .minimum_version_id = 0,
+    .minimum_version_id_old = 0,

same

If you remove the version fields: Reviewed-by: Marc-André Lureau
<marcandre.lur...@redhat.com>

This is the error I got when setting .version_id = 0 (on both) and doing a
localhost migration

qemu-system-x86_64: Missing section footer for tpm-tis
qemu-system-x86_64: load of migration failed: Invalid argument

It's clearly not the most friendly error message, but I debugged it,
you just have to specify the right version for VMSTATE_STRUCT_ARRAY:
0.
         VMSTATE_STRUCT_ARRAY(loc, TPMState, TPM_TIS_NUM_LOCALITIES, 0,
                              vmstate_locty, TPMLocality),

Then it all works with version 0 (or default value)

thanks

Thanks.