On Tue, Apr 03, 2018 at 08:02:44AM -0500, Eric Blake wrote: > On 04/03/2018 12:01 AM, Peter Xu wrote: > > Eric Auger reported the problem days ago that OOB broke ARM when running > > with libvirt: > > > > http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg06231.html > > > > This patch fixes the problem. > > > > It's not really needed now since we have turned OOB off now, but it's > > still a bug fix, and it'll start to work when we turn OOB on for ARM. > > It may be more than just ARM affected, and just that ARM happened to > trigger the problem easier.
Yes. Please feel free to add something to the commit message if you think necessary. [...] > > This patch will fix all known OOB breakages I know so far, but I think > > for better safety I'll still keep OOB off, and I'll send another patch > > to turn default OOB on after 2.12 release. > > Yes, leaving OOB defaulting to off unless you use x-oob=on for 2.12 is > the most conservative action, although we still want to fix all known > bugs that you can trigger by using that. > > How did you run iotests with OOB on by default, by recompiling the > binary to undo commit be933ffc2, or by tweaking the iotests scripts to > pass x-oob=on by default? Not really undo be933ffc2, but pick up 3fd2457d18 manually. Thanks, -- Peter Xu