On 04/03/2018 07:26 PM, Alex Bennée wrote:
> You don't use it yet but probably worth a:
>
> static inline int ffr_full_reg_offset(DisasContext *s)
> {
> return pred_full_reg_offset(s, 16);
> }
>
> here when you get to it to avoid the magic 16 appearing in the main code.
Hum. Most of the places that ffr is touched is in sve.decode.
I could certainly enhance the grammar there to allow a symbol
there instead of a number.
But I don't think treating ffr differently from a regular pr
register, as above, is a good idea. At best I would use
pred_full_reg_offset(s, FFR_PRED_NUM)
or something.
r~
