On Sun, Jan 23, 2011 at 04:50:34PM +0100, Andreas Färber wrote: > Am 21.01.2011 um 23:27 schrieb malc: > >> On Fri, 21 Jan 2011, Blue Swirl wrote: >> >>> On Fri, Jan 21, 2011 at 10:53 AM, Isaku Yamahata >>> <yamah...@valinux.co.jp> wrote: >>>> consolidate audio_init() and remove references to shoundhw. >>>> >>>> Cc: Blue Swirl <blauwir...@gmail.com> >>>> Signed-off-by: Isaku Yamahata <yamah...@valinux.co.jp> >> >> Don't see the point of first hunk. No objections otherwise. > > I guess the point is to limit use of 'soundhw' to arch_init.c rather > than to anyone including sysemu.h? > The definition of the struct is moved there and the variable is made > static.
That's right. Thank you for explanation. I didn't see any reason why the definition of struct soundhw is used anywhere else. > >>> >>> Acked-by: Blue Swirl <blauwir...@gmail.com> > -- yamahata