Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180410193919.28026-1-alex.ben...@linaro.org Subject: [Qemu-devel] [PATCH v1 00/24] fix building of tests/tcg === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180410193919.28026-1-alex.ben...@linaro.org -> patchew/20180410193919.28026-1-alex.ben...@linaro.org Switched to a new branch 'test' 90c03a56a7 tests/Makefile.include: add (clean-)check-tcg targets 4d10ecddd9 Makefile.target: add (clean-)guest-tests targets 419d213b73 tests/tcg/Makefile: update to be called from Makefile.target 42375e278e tests/tcg: enable building for ppc64 48844c4a0b tests/tcg: enable building for s390x 30148808c5 tests/tcg: move MIPS specific tests into subdir 2e1ca97890 tests/tcg/arm: fix hello-arm 7e47cb78d1 tests/tcg: move ARM specific tests into subdir ae14cce45a tests/tcg/i386: fix test-i386-fprem fff9127a52 tests/tcg/i368: fix hello-i386 32defdca05 tests/tcg/i386: fix test-i386 f29d705818 tests/tcg/i386: move test-i386-sse.c to tests/tcg/x86_64/test-sse.c 420cad3ca6 tests/tcg/i386: Build fix for hello-i386 b9c79e9220 tests/tcg: move i386 specific tests into subdir d3d8bafea4 tests/tcg/multiarch: Build fix for linux-test a0e4f21091 tests/tcg: move architecture independent tests into subdir 4b155dc50c docker: Makefile.include introduce DOCKER_SCRIPT a8974c3037 docker: allow "cc" command to run in user context 2b879dfb5c docker: extend "cc" command to accept compiler 948d434a34 docker: Add "cc" subcommand 6464064827 Makefile: Rename TARGET_DIRS to TARGET_LIST ca85716ee3 configure: move i386_cc to cross_cc_i386 d0197823de configure: add support for --cross-cc-FOO ebd12f8f96 configure: add test for docker availability === OUTPUT BEGIN === Checking PATCH 1/24: configure: add test for docker availability... Checking PATCH 2/24: configure: add support for --cross-cc-FOO... Checking PATCH 3/24: configure: move i386_cc to cross_cc_i386... Checking PATCH 4/24: Makefile: Rename TARGET_DIRS to TARGET_LIST... Checking PATCH 5/24: docker: Add "cc" subcommand... Checking PATCH 6/24: docker: extend "cc" command to accept compiler... Checking PATCH 7/24: docker: allow "cc" command to run in user context... Checking PATCH 8/24: docker: Makefile.include introduce DOCKER_SCRIPT... Checking PATCH 9/24: tests/tcg: move architecture independent tests into subdir... Checking PATCH 10/24: tests/tcg/multiarch: Build fix for linux-test... ERROR: if this code is redundant consider removing it #152: FILE: tests/tcg/multiarch/linux-test.c:323: +#if 0 total: 1 errors, 0 warnings, 185 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/24: tests/tcg: move i386 specific tests into subdir... Checking PATCH 12/24: tests/tcg/i386: Build fix for hello-i386... ERROR: externs should be avoided in .c files #20: FILE: tests/tcg/i386/hello-i386.c:23: +void _start(void); total: 1 errors, 0 warnings, 7 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 13/24: tests/tcg/i386: move test-i386-sse.c to tests/tcg/x86_64/test-sse.c... ERROR: code indent should never use tabs #36: FILE: tests/tcg/x86_64/test-sse.c:44: +^I/* SSE4 popcnt r64, r/m64 */$ total: 1 errors, 0 warnings, 21 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 14/24: tests/tcg/i386: fix test-i386... Checking PATCH 15/24: tests/tcg/i368: fix hello-i386... Checking PATCH 16/24: tests/tcg/i386: fix test-i386-fprem... Checking PATCH 17/24: tests/tcg: move ARM specific tests into subdir... Checking PATCH 18/24: tests/tcg/arm: fix hello-arm... Checking PATCH 19/24: tests/tcg: move MIPS specific tests into subdir... Checking PATCH 20/24: tests/tcg: enable building for s390x... Checking PATCH 21/24: tests/tcg: enable building for ppc64... Checking PATCH 22/24: tests/tcg/Makefile: update to be called from Makefile.target... Checking PATCH 23/24: Makefile.target: add (clean-)guest-tests targets... Checking PATCH 24/24: tests/Makefile.include: add (clean-)check-tcg targets... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com