On 01/24/11 17:10, Markus Armbruster wrote: > jes.soren...@redhat.com writes: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> isspace() behavior is undefined for signed char. >> >> Bug pointed out by Eric Blake, thanks! >> >> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> >> --- >> cutils.c | 7 ++++--- >> 1 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/cutils.c b/cutils.c >> index 4d2e27c..a067cf4 100644 >> --- a/cutils.c >> +++ b/cutils.c >> @@ -294,7 +294,8 @@ int fcntl_setfl(int fd, int flag) >> int64_t strtosz_suffix(const char *nptr, char **end, const char >> default_suffix) >> { >> int64_t retval = -1; >> - char *endptr, c, d; >> + char *endptr; >> + unsigned char c, d; >> int mul_required = 0; >> double val, mul, integral, fraction; >> > > I doubt this hunk is still needed.
It isn't strictly due to qemu_toupper() but it is prettier to match the real behavior of pure toupper() anyway. Jes