On 19 April 2018 at 23:09, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > 4c3119a6e3e and cd9526ab7c0 introduced an incorrect and inconsistent > use of Chardev->be. Also, this CharBackend member is private and is > not supposed to be accessible. > > Fix it by removing the inconsistent check. > > Reported-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> > --- > hw/isa/isa-superio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/isa/isa-superio.c b/hw/isa/isa-superio.c > index b95608a003..08afe44731 100644 > --- a/hw/isa/isa-superio.c > +++ b/hw/isa/isa-superio.c > @@ -43,7 +43,7 @@ static void isa_superio_realize(DeviceState *dev, Error > **errp) > if (!k->parallel.is_enabled || k->parallel.is_enabled(sio, i)) { > /* FIXME use a qdev chardev prop instead of parallel_hds[] */ > chr = parallel_hds[i]; > - if (chr == NULL || chr->be) { > + if (chr == NULL) { > name = g_strdup_printf("discarding-parallel%d", i); > chr = qemu_chr_new(name, "null"); > } else { > @@ -83,7 +83,7 @@ static void isa_superio_realize(DeviceState *dev, Error > **errp) > if (!k->serial.is_enabled || k->serial.is_enabled(sio, i)) { > /* FIXME use a qdev chardev prop instead of serial_hds[] */ > chr = serial_hds[i]; > - if (chr == NULL || chr->be) { > + if (chr == NULL) { > name = g_strdup_printf("discarding-serial%d", i); > chr = qemu_chr_new(name, "null"); > } else {
You should not need to create fake null devices like this. The device using the chardev should just cope with having a NULL pointer now we have commit 12051d82f004024. Also consider having cc:stable on this patchset? thanks -- PMM