On Tue, Apr 24, 2018 at 12:51:10 +0800, Peter Xu wrote: > Introduce some hooks for the shared part of qemu thread between POSIX > and Windows implementations. Note that in qemu_mutex_unlock_impl() we > moved the call before unlock operation which should make more sense. > And we don't need qemu_mutex_post_unlock() hook. > > Currently the hooks only calls the tracepoints.
This line is obsolete -- in _init we set ->initialized. > Put all these shared hooks into the header files. It should be internal > to qemu-thread but not for qemu-thread users, hence put into util/ > directory. > > Signed-off-by: Peter Xu <pet...@redhat.com> > --- (snip) > +++ b/util/qemu-thread-common.h (snip) > +#ifndef __QEMU_THREAD_COMMON_H__ > +#define __QEMU_THREAD_COMMON_H__ Please change to QEMU_THREAD_COMMON_H, without the double underscore. (_* and __* identifiers are reserved for the C library) Otherwise: Reviewed-by: Emilio G. Cota <c...@braap.org> Thanks, Emilio