On 24.04.2018 19:58, Ian Jackson wrote:
> I'm going to be editing this function and it makes sense to clean up
> this style problem in advance.
>
> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com>
> CC: Paolo Bonzini <pbonz...@redhat.com>
> CC: Markus Armbruster <arm...@redhat.com>
> CC: Daniel P. Berrange <berra...@redhat.com>
> CC: Michael Tokarev <m...@tls.msk.ru>
> ---
> os-posix.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/os-posix.c b/os-posix.c
> index b9c2343..560db95 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -167,20 +167,20 @@ static void change_process_uid(void)
> {
> if (user_pwd) {
> if (setgid(user_pwd->pw_gid) < 0) {
> - fprintf(stderr, "Failed to setgid(%d)\n", user_pwd->pw_gid);
> + error_report("Failed to setgid(%d)", user_pwd->pw_gid);
> exit(1);
> }
> if (initgroups(user_pwd->pw_name, user_pwd->pw_gid) < 0) {
> - fprintf(stderr, "Failed to initgroups(\"%s\", %d)\n",
> - user_pwd->pw_name, user_pwd->pw_gid);
> + error_report("Failed to initgroups(\"%s\", %d)",
> + user_pwd->pw_name, user_pwd->pw_gid);
> exit(1);
> }
> if (setuid(user_pwd->pw_uid) < 0) {
> - fprintf(stderr, "Failed to setuid(%d)\n", user_pwd->pw_uid);
> + error_report("Failed to setuid(%d)", user_pwd->pw_uid);
> exit(1);
> }
> if (setuid(0) != -1) {
> - fprintf(stderr, "Dropping privileges failed\n");
> + error_report("Dropping privileges failed");
> exit(1);
> }
> }
>
Reviewed-by: Thomas Huth <th...@redhat.com>
