Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 1524648037-5010-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1524648037-5010-1-git-send-email-whois.zihan.y...@gmail.com -> patchew/1524648037-5010-1-git-send-email-whois.zihan.y...@gmail.com Switched to a new branch 'test' 361db0df59 hw/pci-host/q35: Replace hardcoded value with macro === OUTPUT BEGIN === Checking PATCH 1/1: hw/pci-host/q35: Replace hardcoded value with macro... ERROR: line over 90 characters #22: FILE: hw/pci-host/q35.c:538: + mch->pci_address_space, MCH_HOST_BRIDGE_SMRAM_C_BASE, MCH_HOST_BRIDGE_SMRAM_C_SIZE); WARNING: line over 80 characters #23: FILE: hw/pci-host/q35.c:539: + memory_region_add_subregion_overlap(mch->system_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE, ERROR: line over 90 characters #29: FILE: hw/pci-host/q35.c:544: + mch->ram_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE, MCH_HOST_BRIDGE_SMRAM_C_SIZE); WARNING: line over 80 characters #38: FILE: hw/pci-host/q35.c:553: + mch->ram_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE, 0x20000); ERROR: line over 90 characters #41: FILE: hw/pci-host/q35.c:555: + memory_region_add_subregion(&mch->smram, MCH_HOST_BRIDGE_SMRAM_C_BASE, &mch->low_smram); ERROR: line over 90 characters #44: FILE: hw/pci-host/q35.c:557: + mch->ram_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE, MCH_HOST_BRIDGE_SMRAM_C_SIZE); total: 4 errors, 2 warnings, 30 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com