>>> int ret; >>> @@ -346,6 +355,14 @@ static void ccw_init(MachineState *machine) >>> /* Create VirtIO network adapters */ >>> s390_create_virtio_net(BUS(css_bus), "virtio-net-ccw"); >>> >>> + /* init consoles */ >>> + if (serial_hds[0]) { >>> + s390_create_sclpconsole("sclpconsole", serial_hds[0]); >>> + } >>> + if (serial_hds[1]) { >>> + s390_create_sclpconsole("sclplmconsole", serial_hds[1]); >>> + } >> >> What happens if more -serial are defined? An error? Silently ignored? > > Silently ignored, since this is also what almost all other machines are > doing (look for serial_hds in hw/ and you'll see what I mean). > >> (e.g. do we have to redefine MAX_SERIAL_PORTS on s390x or add checking >> code here?) > > As all the other machines are also not redefining MAX_SERIAL_PORTS, I > think we should also not do this on s390x now, should we?
Then I guess if we would introduce it, we should do it for all other implementations. So I think we can just leave it as it is. > > Thomas > -- Thanks, David / dhildenb