On 04/26/2018 11:53 AM, Ian Jackson wrote: > Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> > --- > HACKING | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/HACKING b/HACKING > index 4125c97..95563a3 100644 > --- a/HACKING > +++ b/HACKING > @@ -189,6 +189,7 @@ error_report() or error_vreport() from error-report.h. > This ensures the > error is reported in the right place (current monitor or stderr), and in > a uniform format. > > +Use error_report_errno rather than open-coding calls to strerror(). > Use error_printf() & friends to print additional information.
Our style is to write this as error_report_errno(). Or even copy the approach used in the next line, stating 'error_report_errno() & friends'. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature