> Headers usually start with a one-line summary, "QEMU simulated block > driver" maybe? > > + * Copyright (c) 2010-2011 IBM > > + * > > + * Authors: > > + * Chunqiang Tang <ct...@us.ibm.com> > > + * > > + * This work is licensed under the terms of the GNU GPL, version 2. > > + * See the COPYING file in the top-level directory. > > Can you make this GPLv2-or-later to avoid future hassles?
Will do. > > +#ifndef TRUE > > +# define TRUE 1 > > +#endif > > + > > +#ifndef FALSE > > +# define FALSE 0 > > +#endif > > I don't think these two belong here. > > stdbool.h defines true and false with identical values. > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/stdbool.h.html > > Not sure about TRUE and FALSE. > If we want them as local definitions, they should rather go to qemu- > common.h than to individual source files. You are right. "true" and "false" should be used instead, and qemu-common.h already includes stdbool.h.
