On 05/01/2018 10:55 AM, Vladimir Sementsov-Ogievskiy wrote:
01.05.2018 18:46, Eric Blake wrote:
A missing space makes for poor error messages. Also, we missed
diagnosing a server that sends a maximum block size less than
the minimum.
Fixes: 081dd1fe
CC: qemu-sta...@nongnu.org
Signed-off-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
nbd/client.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/nbd/client.c b/nbd/client.c
index 7f35b5c3232..7b3caa90ec2 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -436,7 +436,7 @@ static int nbd_opt_go(QIOChannel *ioc, const char
*wantname,
be32_to_cpus(&info->min_block);
if (!is_power_of_2(info->min_block)) {
error_setg(errp, "server minimum block size %" PRId32
- "is not a power of two", info->min_block);
+ " is not a power of two", info->min_block);
One more tweak: PRIu32 is better than PRId32, as block sizes cannot go
negative. I'm squashing that in, then staging this on my NBD queue.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
