On 05/07/2018 12:44 PM, Eric Blake wrote: > On 05/07/2018 09:30 AM, Collin Walling wrote: >> When a user incorrectly provides an hmp command, an error response will be >> printed that prompts the user to try "help <command name>". However, when >> the command contains multiple parts e.g. "info uuid xyz", only the last >> whitespace delimited string will be reported (in this example "info" will >> be dropped and the message will read "Try "help uuid" for more information", >> which is incorrect). >> >> Let's correct this by capturing the entirety of the command from the command >> line -- excluding any extraneous characters. >> > > It's better to post a v2 patch as a new top-level thread instead of in-reply > to an earlier version, as some of our automated tooling is more likely to see > it. > >> Reported-by: Mikhail Fokin <fo...@de.ibm.com> >> Signed-off-by: Collin Walling <wall...@linux.ibm.com> >> --- >> monitor.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> >
Noted. And thank you for the r-b. -- Respectfully, - Collin Walling
