On Fri, 4 May 2018 02:24:12 +0200 Thomas Huth <th...@redhat.com> wrote:
> On 03.05.2018 21:50, Michael S. Tsirkin wrote: > > we just need a struct name, let's add a forward > > declaration instead of an include. > > > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > > --- > > include/hw/s390x/sclp.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h > > index f9db243..6e65150 100644 > > --- a/include/hw/s390x/sclp.h > > +++ b/include/hw/s390x/sclp.h > > @@ -16,7 +16,8 @@ > > > > #include "hw/sysbus.h" > > #include "hw/qdev.h" > > -#include "target/s390x/cpu-qom.h" > > + > > +typedef struct CPUS390XState CPUS390XState; > > IIRC you have to use include/qemu/typedefs.h instead to avoid trouble > with older versions of GCC. Hm, I'm wondering why we do the typedef in cpu-qom.h, while other architectures do it in their cpu.h.
