"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> Reviewed-by: Peter Xu <pet...@redhat.com>
>> + >> + migrate_set_parameter(from, "xbzrle-cache-size", "33554432"); > > I still worry about the cache size relative to the size of memory we're > actually changing in the test; I don't quite understand why it's turning > out to get lots of hits. I planned this as a smorke test. But what value do you have in mind? > Also, xbzrle eats so much CPU we'll still have to watch out for the low > end CPUs. Any concrete suggestion? My plan would have been to push on my next pull request: Add migration precopy test Add migration xbzrle test Migration ppc now inlines its program And put the rest of the patches with fixes for another review. Later, Juan.
