On 01/24/11 15:50, Chunqiang Tang wrote: >> I think the root of the problem is that your series didn't maintain >> bisectability. >> >> IOW, each patch needs to be able to be applied one at a time such that >> at each point, the build doesn't break and functionality doesn't break. >> >> Otherwise, tools like git bisect don't work. > > This was true with the old, big FVD patches you reviewed. Following > Christoph Hellwig's suggestion, the new series of FVD patches submitted > last Friday, e.g., "FVD: Added the simulated 'blksim' driver", add > individual smaller functions and breaks neither compilation nor execution.
Then you need to break up the new patch into smaller chunks and make sure they can each be applied without breaking the build. Having a separate patch that moves functions to another file, because they are too be shared, is a completely valid patch. Jes
