Peter Xu <pet...@redhat.com> wrote:
> On Wed, Apr 25, 2018 at 01:27:12PM +0200, Juan Quintela wrote:
>
> [...]
>
>> +static void multifd_pages_init(MultiFDPages_t **ppages, size_t size)
>> +{
>> + MultiFDPages_t *pages = g_new0(MultiFDPages_t, 1);
>> +
>> + pages->allocated = size;
>> + pages->iov = g_new0(struct iovec, size);
>> + pages->offset = g_new0(ram_addr_t, size);
>> + *ppages = pages;
>> +}
>
> Can we just return the pages pointer? Then it can be:
>
> static MultiFDPages_t *multifd_pages_init(size_t size)
Done.
>
> [...]
>
>> @@ -731,6 +784,7 @@ static void *multifd_recv_thread(void *opaque)
>> int multifd_load_setup(void)
>> {
>> int thread_count;
>> + uint32_t page_count = migrate_multifd_page_count();
>> uint8_t i;
>>
>> if (!migrate_use_multifd()) {
>> @@ -740,6 +794,7 @@ int multifd_load_setup(void)
>> multifd_recv_state = g_malloc0(sizeof(*multifd_recv_state));
>> multifd_recv_state->params = g_new0(MultiFDRecvParams, thread_count);
>> atomic_set(&multifd_recv_state->count, 0);
>> +
>
> Useless line?
Changed it a lot in other places.
Later, Juan.
