On 9 May 2018 at 06:32, David Gibson <da...@gibson.dropbear.id.au> wrote: > On Sun, May 06, 2018 at 04:04:02PM +0100, Peter Maydell wrote: >> On 6 May 2018 at 14:39, David Gibson <da...@gibson.dropbear.id.au> wrote: >> > Although, that said, I'll re-iterate that I think qemu's fdt >> > manipulation is now sufficiently complex that it would be better off >> > using a "live" (dynamically allocated & pointer based) tree >> > representation that we just flatten immediately before loading it into >> > the guest. >> >> This sounds to me like something that should be handled >> by libfdt. > > No, it's really not. libfdt is specifically for reading and writing > flattened trees in place, in flattened form. That's the whole basis > of the design and it's directly responsible for some of the > infelicities you mention. > > I was never intended as a general runtime t manipulation library. A > libdt that does that (using an allocator and internal pointer > representation) would be a nice thing to have, but libfdt isn't it. > Obviously being able to use libfdt to flatten and unflatten trees > would be a very good feature for such a library.
The difficulty is that libfdt is the closest we have to a dt manipulation library. The current wrapper layer is sort of trying to fix up its deficiencies for this use case. I just think that libfdt (as project, not necessarily as a single source file or library) is better placed to design and implement a more featured dt manipulation library layer than QEMU is. (Possibly we have here a slight terminology confusion: when I think about "libfdt" what I mean is "the project that has code for manipulating device trees and provides a library and some source files you can compile directly into a kernel or bootloader and a standalone dtc compiler binary and so on", not "specifically a single library". So it seems to me more natural for generic library code for manipulating DTs with an unflatten-manipulate-flatten approach would also be part of that project.) >> internal representation of the data structure is, I just >> want to be able to (a) hand it an fdt read in from a file >> (b) call various functions to modify the data structure >> and then (c) write the resulting thing out to an fdt in >> guest memory. Whether libfdt prefers to do that by >> modifying the flat representation or by converting into >> a dynamically allocated unflattened tree and back again >> is something I'd rather leave to it as an implementation >> detail. > > Sort of. But there design constraints in libfdt which means that's > not really feasible. Such as: > * not requiring an allocator > * not requiring a "read / unflatten" pass before reading values from > an fdt > * not requiring allocation or creation of a "context" state for > manipulating a tree > > Those aren't aren't really relevant to qemu and perhaps aren't part of > what you'd usually think of as the API. But they do matter to real > libfdt use cases. Yes, you'd certainly want to keep the compile time option to just have the "no allocation" parts of the library so you could build it into kernels and boot loaders. thanks -- PMM
