On Tue, May 8, 2018 at 8:46 PM, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com>
Alistair
> ---
> hw/sd/ssi-sd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c
> index 77e446bb94..0375f0b959 100644
> --- a/hw/sd/ssi-sd.c
> +++ b/hw/sd/ssi-sd.c
> @@ -95,11 +95,11 @@ static uint32_t ssi_sd_transfer(SSISlave *dev, uint32_t
> val)
> if (s->arglen == 4) {
> uint8_t request[6];
> uint8_t longresp[16];
> - /* FIXME: Check CRC. */
>
> DPRINTF("CMD%d arg 0x%08x\n", s->cmd, ldl_be_p(s->cmdarg));
> sd_frame48_init(request, sizeof(request), s->cmd,
> ldl_be_p(s->cmdarg), false);
> + request[5] = sd_frame48_calc_checksum(request);
>
> s->arglen = sdbus_do_command(&s->sdbus, request, longresp);
> if (s->arglen <= 0) {
> @@ -257,6 +257,7 @@ static void ssi_sd_realize(SSISlave *d, Error **errp)
> qdev_prop_set_drive(carddev, "drive", blk_by_legacy_dinfo(dinfo),
> &err);
> }
> object_property_set_bool(OBJECT(carddev), true, "spi", &err);
> + object_property_set_bool(OBJECT(carddev), true, "validate-crc", &err);
> object_property_set_bool(OBJECT(carddev), true, "realized", &err);
> if (err) {
> error_setg(errp, "failed to init SD card: %s",
> error_get_pretty(err));
> --
> 2.17.0
>
>
