On 14 May 2018 at 23:12, Richard Henderson <richard.hender...@linaro.org> wrote: > Only MIPS requires snan_bit_is_one to be variable. While we are > specializing softfloat behaviour, allow other targets to eliminate > this runtime check. > > Cc: Aurelien Jarno <aurel...@aurel32.net> > Cc: Yongbok Kim <yongbok....@mips.com> > Cc: David Gibson <da...@gibson.dropbear.id.au> > Cc: Alexander Graf <ag...@suse.de> > Cc: Guan Xuetao <g...@mprc.pku.edu.cn> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > > --- > v5 > - do not remove the set_snan_bit_is_one function > - tidy the language in the snan_bit_is_one block comment
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> I think this change makes the comments in target/riscv/fpu_helper.c helper_fclass_s() and helper_fclass_d() stale, incidentally. thanks -- PMM
