On 13 May 2018 at 10:57, Stefan Weil <s...@weilnetz.de> wrote:
> Even with the above patch, disas/libvixl raises a compiler warning for a
> fall through case. The patch below fixes that warning, but I am not sure
> whether a fall through is correct there.
>
> Stefan
>
>
> diff --git a/disas/libvixl/vixl/a64/disasm-a64.cc
> b/disas/libvixl/vixl/a64/disasm-a64.cc
> index 7a58a5c087..5481d94209 100644
> --- a/disas/libvixl/vixl/a64/disasm-a64.cc
> +++ b/disas/libvixl/vixl/a64/disasm-a64.cc
> @@ -2986,6 +2986,7 @@ int Disassembler::SubstituteImmediateField(const
> Instruction* instr,
> return 3;
> }
> }
> + VIXL_FALLTHROUGH(); // ???
> }
> case 'C': { // ICondB - Immediate Conditional Branch.
> int64_t offset = instr->ImmCondBranch() << 2;
This is fixed in upstream vixl, in fact:
https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337fda52845ed3d2e620cc02
thanks
-- PMM
