On Wed, May 09, 2018 at 01:51:31PM -0700, Richard Henderson wrote: > On 05/08/2018 10:31 AM, Edgar E. Iglesias wrote: > > + if (cpu->cfg.use_mmu && (env->sregs[SR_MSR] & MSR_VM) > > + && mmu_idx != MMU_NOMMU_IDX) { > > For future cleanup, the first condition should be moved to cpu_mmu_index (the > second condition is already there). At which point here you need check > nothing > but mmu_idx.
Thanks, I've added a followup patch that does this. Cheers, Edgar