On 05/18/18 14:23, marcandre.lur...@redhat.com wrote: > diff --git > a/OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > b/OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > new file mode 100644 > index 000000000000..92ce5f04b37f > --- /dev/null > +++ > b/OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf > @@ -0,0 +1,33 @@ > +## @file > +# NULL Tcg2PhysicalPresenceLib library instance > +# > +# Under SecurityPkg, the corresponding library instance will check and > +# execute TPM 2.0 request from OS or BIOS; the request may ask for user > +# confirmation before execution. This Null instance implements a no-op > +# Tcg2PhysicalPresenceLibProcessRequest(), without user interaction. > +# > +# Copyright (C) 2018, Red Hat, Inc. > +# Copyright (c) 2013 - 2016, Intel Corporation. All rights reserved.<BR> > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD > License > +# which accompanies this distribution. The full text of the license may be > found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR > IMPLIED. > +# > +## > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = DxeTcg2PhysicalPresenceLibNull > + FILE_GUID = 2A6BA243-DC22-42D8-9C3D-AE3728DC7AFA > + MODULE_TYPE = DXE_DRIVER > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = Tcg2PhysicalPresenceLib|DXE_DRIVER > DXE_RUNTIME_DRIVER DXE_SAL_DRIVER UEFI_APPLICATION UEFI_DRIVER > + > +[Sources] > + DxeTcg2PhysicalPresenceLib.c > + > +[Packages] > + MdeModulePkg/MdeModulePkg.dec > + SecurityPkg/SecurityPkg.dec
Here my suggestion was to drop MdeModulePkg.dec, and keep MdePkg.dec and SecurityPkg.dec. Anyway, I plan to fix that up for you. With it fixed: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks Laszlo