On 05/24/2018 10:52 AM, Eric Blake wrote:
Also, since waitpid() can only return either s->qemu_pid or -1 as we aren't using WNOHANG, it may also be worth asserting that if pid == -1, we either have EAGAIN (but why aren't we looping in that case?) or ECHILD.
I meant EINTR, not EAGAIN. But in general, using waitpid() to collect process status without doing it in a loop is risky.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
