On 25 May 2018 at 07:18, Michael Clark <m...@sifive.com> wrote: > On Fri, May 25, 2018 at 9:54 AM, Richard Henderson <r...@twiddle.net> wrote: > >> In the latest Coverity scan, it reports
>> I believe the condition at op_helper.c:409 should be testing >> CSR_MHPMCOUNTER3H >> and CSR_MHPMCOUNTER31H. Must run now, otherwise I'd also send the trivial >> patch. > > > Thanks! Yes indeed they should be the H versions. > > I will send the trivial patch... You might like to sign up to our Coverity Scan project if you aren't already: https://scan.coverity.com/projects/qemu?tab=overview It reports a couple of other riscv coverity nits (minor memory leaks). thanks -- PMM