On Thu, May 24, 2018 at 01:16:11PM +0200, Markus Armbruster wrote: > Peter Xu <pet...@redhat.com> writes: > > > On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote: > >> Regarding the subject: what are "fleids"? > > > > Ouch. :( I meant the word "fields". > > Can touch that up in my tree.
[...] > >> > + /* > >> > + * State used only in the thread "owning" the monitor. > >> > + * If @use_io_thr, this is mon_global.mon_iothread. > >> > + * Else, it's the main thread. > >> > + * These members can be safely accessed without locks. > >> > + */ > >> > ReadLineState *rs; > >> > + // other members that aren't shared > >> > >> Whoops, misunderstanding! I meant this line as a placeholder, to > >> further illustrate my intent. It should not be committed. If we need a > >> comment here, it should use /* traditional comment syntax */. > > > > My fault. > > > > Please let me know if you want me to repost... Thanks, > > Can touch that up, too. No respin needed unless something more complex > comes up. I'll modify these two parts in my next post. Regards, -- Peter Xu