On Thu, 24 May 2018 17:42:03 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> Eduardo Habkost <ehabk...@redhat.com> writes: > > > I'm queueing this version (including v8 of patches 5-7) on > > numa-next. > > > > Markus, Daniel: you were the people I remember expressing some > > concerns about the new preconfig mechanism. Do you have any > > objections to this version? > > My gut's reaction to preconfig is as nauseous as ever. It adds > complexity we wouldn't want or need with sanely structured program > startup. It might still be the best we can do, and something we need to > do. You have to take on technical debt sometimes. To know for sure > this is the case here, we'd have to explore alternatives more seriously. > Like repaying some of the existing technical debt around there. Sadly, > I lack the time to take on such a project. Usually I do quite a bit of re-factoring to reduce our technical debt, so while working on enabling VM start with libvirt using only --preconfig (without -S) I most likely will have to improve code around VM creation. [...]