[adding Markus, as the error maintainer]
On 05/29/2018 09:33 AM, Philippe Mathieu-Daudé wrote:
Ok I see, Clang is unaware than error_setg(&error_fatal) is a noreturn.
Indeed, and that's because error_setg(&error_fatal) is not in preferred
form.
Patch dropped.
That's a shame. Rather, we should patch this file (and others) to avoid
all the inconsistent uses of error_setg(&error_*), to comply with the
error.h documentation.
I started to port/clean this up.
To avoid future inconsistencies, do you think we should/can enforce this
check in checkpatch (which is stricter than human review)?
Sure, automating good code style is worthwhile.
Is the "Qemu error function tests" section a good place to put this check?
Probably works. I'm not familiar enough with checkpatch as a whole to
have any different suggestions off the top of my head (basically, any
time I've touched that file, it's been grepping for something that is
similar to what I want to be tweaking, rather than reading the whole thing).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
