Ping on this series. Rob, I think I've addressed all your feedback. Can you please verify?
Thanks, - Ross On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote: > Changes since v3: > * Updated the text in docs/nvdimm.txt to make it clear that the value > being passed in on the command line in an integer made up of various > bit fields. (Rob Elliott) > > * Updated the "Highest Valid Capability" byte to be dynamic based on > the highest valid bit in the user's input. (Rob Elliott) > > --- > > The first 2 patches in this series clean up some things I noticed while > coding. > > Patch 3 adds support for the new Platform Capabilities Structure, which > was added to the NFIT in ACPI 6.2 Errata A. We add a machine command > line option "nvdimm-cap": > > -machine pc,accel=kvm,nvdimm,nvdimm-cap=2 > > which allows the user to pass in a value for this structure. When such > a value is passed in we will generate the new NFIT subtable. > > Patch 4 adds code to the "make check" self test infrastructure so that > we generate the new Platform Capabilities Structure, and adds it to the > expected NFIT output so that we test for it. > > Ross Zwisler (4): > nvdimm: fix typo in label-size definition > tests/.gitignore: add entry for generated file > nvdimm, acpi: support NFIT platform capabilities > ACPI testing: test NFIT platform capabilities > > docs/nvdimm.txt | 27 ++++++++++++++++++++ > hw/acpi/nvdimm.c | 45 > +++++++++++++++++++++++++++++++--- > hw/i386/pc.c | 31 +++++++++++++++++++++++ > hw/mem/nvdimm.c | 2 +- > include/hw/i386/pc.h | 1 + > include/hw/mem/nvdimm.h | 7 +++++- > tests/.gitignore | 1 + > tests/acpi-test-data/pc/NFIT.dimmpxm | Bin 224 -> 240 bytes > tests/acpi-test-data/q35/NFIT.dimmpxm | Bin 224 -> 240 bytes > tests/bios-tables-test.c | 2 +- > 10 files changed, 109 insertions(+), 7 deletions(-) > > -- > 2.14.3 >