> I'm ok with this move, but if the functions need to have distinct > implementations, and they really do according to patch 10, then > I'd rather have distinct files and rely on conditional building in > the makefile. Maybe rename the current file to 9p-util-linux.c > and introduce a 9p-util-darwin.c later.
Sounds good, I will make this change. >> Additionally, introduce a _follow version of fgetxattr and use it. >> On darwin, fgetxattr has a more general interface, so we'll need to factor >> it out anyway. >> > > No need for the _follow version in this case. I'm not entirely sure what you're proposing. On darwin `fgetxattr` takes two extra arguments, so I believe it needs to be factored out nevertheless. Are you just proposing doing that later in the patch series?