> > Please don't kill the spaces. > Sorry, will undo. My editor has strong opinions about styling.
>> +#ifndef CONFIG_DARWIN >> + {P9_DOTL_NOATIME, O_NOATIME}, >> + /* On Darwin, we could map to F_NOCACHE, which is >> + similar, but doesn't quite have the same >> + semantics. However, we don't support O_DIRECT > > But are these semantics worse than dumping the flag ? > I don't know. I looked around a bit and most OS abstraction layers tend to not do this translation automatically: https://github.com/libuv/libuv/issues/1600 >> + even on linux at the moment, so we just ignore >> + it here. */ > > Yeah, and I doubt we'll ever support it on linux either. But, > anyway, why filter these out ? Do they cause a build break ? > Yes, neither O_DIRECT nor O_NOATIME are defined on Darwin, so trying to use them causes errors.