Hi, This series converts error_setg(&error_fatal) to error_report() + exit() as suggested by the "qapi/error.h" documentation.
This reduce Coverity and Clang static analyzer positive falses. See http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07585.html: On 07/24/2017 04:52 PM, Eric Blake wrote: That's a shame. Rather, we should patch this file (and others) to avoid all the inconsistent uses of error_setg(&error_*), to comply with the error.h documentation. Since v1: - patch #1: use assert() directly (Markus explanation) - patch #2: use abort() without error_report() (Markus 'no lipstick') - patch #3: replaced exit() by assert() (Markus) - patch #4: no change, added R-b Regards, Phil. Philippe Mathieu-Daudé (4): hw/block/fdc: Replace error_setg(&error_abort) by assert() hw/ppc/spapr_drc: Replace error_setg(&error_abort) by abort() hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit() device_tree: Replace error_setg(&error_fatal) by error_report() + exit() device_tree.c | 23 +++++++++++++---------- hw/arm/sysbus-fdt.c | 42 +++++++++++++++++++++++------------------- hw/block/fdc.c | 9 +-------- hw/ppc/spapr_drc.c | 2 +- 4 files changed, 38 insertions(+), 38 deletions(-) -- 2.17.1