On 08.06.2018 11:35, Igor Mammedov wrote: > On Fri, 8 Jun 2018 11:02:23 +0200 > David Hildenbrand <da...@redhat.com> wrote: > >> On 08.06.2018 10:56, Igor Mammedov wrote: >>> On Thu, 7 Jun 2018 18:52:16 +0200 >>> David Hildenbrand <da...@redhat.com> wrote: >>> >>>> Let's handle it via hotplug_handler_unplug(). E.g. necessary to hotplug/ >>>> unplug memory devices (which a pc-dimm is) later. >>> Perhaps something like following would be better: >>> >>> Factor out memory unplug into separate function from spapr_lmb_release(). >>> Then use generic hotplug_handler_unplug() to trigger memory unplug, >>> which would call spapr_machine_device_unplug() -> spapr_memory_unplug() >>> in the end . >>> This way unplug operation is not buried in lmb internals and located >>> in the same place like in other targets, following similar >>> logic/call chain across targets. >> >> Can this be an addon patch? Sounds like factoring out more and moving more. > I've suggested ^^^ it as this patch description instead of the current one > that doesn't really makes the sense on it's own.
Okay, I was definitely misreading your comment :) Will change. -- Thanks, David / dhildenb
