Thanks for the comments! Replying inline.
> -----Original Message----- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Friday, June 1, 2018 6:01 PM > To: Perez Blanco, Ricardo (Nokia - BE/Antwerp) > <ricardo.perez_bla...@nokia.com> > Cc: Dr. David Alan Gilbert <dgilb...@redhat.com>; Markus Armbruster > <arm...@redhat.com>; Andreas Färber <afaer...@suse.de>; open list:All > patches CC here <qemu-devel@nongnu.org> > Subject: Re: [PATCH v2] Show values and description when using "qom-list" > > On 06/01/2018 10:39 AM, Ricardo Perez Blanco wrote: > > For debugging purposes it is very useful to: > > - See the description of the field. This information is already filled > > in but not shown in "qom-list" command. > > - Display value of the field. > > > > Signed-off-by: Ricardo Perez Blanco <ricardo.perez_bla...@nokia.com> > > --- > > > +++ b/qapi/misc.json > > @@ -1328,10 +1328,12 @@ > > # > > # @description: if specified, the description of the property. > > # > > -# Since: 1.2 > > +# @value: if specified, the value of the property. > > +# > > +# Since: 2.13 > > Not quite. The struct was first introduced in 1.2, and only 'value' was added > in 3.0 (since we've renamed 2.13 into 3.0). It should look like: > > # @value: if specified, the value of the property (since 3.0) # # Since: 1.2 > Ok, it completely makes sense. I will fix it. > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org
