Re: [Qemu-devel] [PATCH master/0.14] virtio-serial: Make sure virtqueue is ready before discarding data

[Anthony Liguori]

On 02/04/2011 02:54 AM, Amit Shah wrote:

This can happen if a port gets unplugged before guest has chance to
initialise vqs.

Reported-by: Juan Quintela<quint...@redhat.com>
Signed-off-by: Amit Shah<amit.s...@redhat.com>

Applied to master, Thanks.

Regards,

Anthony Liguori

---
  hw/virtio-serial-bus.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 09e22aa..e05ab5e 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -117,6 +117,9 @@ static void discard_vq_data(VirtQueue *vq, VirtIODevice 
*vdev)
  {
      VirtQueueElement elem;

+    if (!virtio_queue_ready(vq)) {
+        return;
+    }
      while (virtqueue_pop(vq,&elem)) {
          virtqueue_push(vq,&elem, 0);
      }